The default value for NullableString should be null (was "")

mojo/public/tools/bindings/pylib/mojom/generate/module.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This module's classes provide an interface to mojo modules. Modules are
 # collections of interfaces and structs to be used by mojo ipc clients and
 # servers.
 #
 # A simple interface would be created this way:
 # module = mojom.generate.module.Module('Foo')
@@ skipping 316 matching lines @@
   def AddStruct(self, name):
     struct=Struct(name, module=self)
     self.structs.append(struct)
     return struct
 
 
 def IsBoolKind(kind):
   return kind.spec == BOOL.spec
 
 
+def IsFloatKind(kind):
+  return kind is not None and kind.spec == FLOAT.spec

[yzshen1, 2014/09/24 22:49:25]

nit: All surrounding functions don't test kind is not None. It might make
readers wonder why this one is special.

[hansmuller, 2014/09/24 23:33:11]

I've moved to the "is not None" test to the call site.

+
+
 def IsStringKind(kind):
   return kind.spec == STRING.spec or kind.spec == NULLABLE_STRING.spec
 
 
 def IsHandleKind(kind):
   return kind.spec == HANDLE.spec or kind.spec == NULLABLE_HANDLE.spec
 
 
 def IsDataPipeConsumerKind(kind):
   return kind.spec == DCPIPE.spec or kind.spec == NULLABLE_DCPIPE.spec
@@ skipping 69 matching lines @@
 def IsMoveOnlyKind(kind):
   return IsObjectKind(kind) or IsAnyHandleKind(kind)
 
 
 def HasCallbacks(interface):
   for method in interface.methods:
     if method.response_parameters != None:
       return True
   return False