mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 605443002: The default value for NullableString should be null (was "")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 605443002: The default value for NullableString should be null (was "") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test fields with type double Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/js/bindings/struct_unittests.js ('K') | « mojo/public/js/bindings/struct_unittests.js ('k') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('j') | mojo/public/tools/bindings/pylib/mojom/generate/module.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index 8a17f841e7f71a1fbc64887ad90d39984107b063..14c069f89e477ba100ced602df72856c7273c999 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -233,6 +233,9 @@ def TranslateConstants(token, kind):

if token.value == "double.NAN" or token.value == "float.NAN":

return "NAN";

+ if (mojom.IsFloatKind(kind)):

+ return token if token.isdigit() else token + "f";

return '%s%s' % (token, _kind_to_cpp_literal_suffix.get(kind, ''))

def ExpressionToText(value, kind=None):