Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 605433003: [NaCl SDK] nacl_io: Fix gaping memory leaks in memfs and htmlfs (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_nacl_io
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Fix gaping memory leaks in memfs and htmlfs I introduced these leaks recently and really should have run valgrind. In future out valgrind bot should find such things pre-submit. Committed: https://crrev.com/67c19dd9512866cf31bae844300cf86f19338a0c Cr-Commit-Position: refs/heads/master@{#296606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.h View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
6 years, 3 months ago (2014-09-24 23:35:28 UTC) #2
binji
yikes, lgtm
6 years, 2 months ago (2014-09-24 23:58:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605433003/1
6 years, 2 months ago (2014-09-25 00:02:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ff5165d96612232464a7ae9dee452b9642fe1b67
6 years, 2 months ago (2014-09-25 01:11:21 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 01:11:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67c19dd9512866cf31bae844300cf86f19338a0c
Cr-Commit-Position: refs/heads/master@{#296606}

Powered by Google App Engine
This is Rietveld 408576698