native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.h - Issue 605433003: [NaCl SDK] nacl_io: Fix gaping memory leaks in memfs and htmlfs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.h

Issue 605433003: [NaCl SDK] nacl_io: Fix gaping memory leaks in memfs and htmlfs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_nacl_io

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.h

diff --git a/native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.h b/native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.h

index 7172e1fe286a2c34fba14c0a98746be48747b44f..253f76832540f3272b8c3a74d4743c1f12775674 100644

--- a/native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.h

+++ b/native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.h

@@ -42,6 +42,8 @@ class HttpFsNode : public Node {

const std::string& url,

bool cache_content);

+ virtual ~HttpFsNode();

private:

Error GetStat_Locked(struct stat* stat);

Error OpenUrl(const char* method,

« no previous file with comments | « no previous file | native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc » ('j') | no next file with comments »