Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Issue 605283002: Subzero: Change szbuild.py to prefer Subzero by default. (Closed)

Created:
6 years, 2 months ago by Jim Stichnoth
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Change szbuild.py to prefer Subzero by default. Subzero translation is stable enough that szbuild.py should prefer Subzero-translated symbols by default. The exception is that if you explicitly use --include, the intuitive interpretation is that you only want Subzero to include those symbols (minus any given with --exclude). BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=be22e1462bc9873cd4f2f2ff2706f6e1426a9dc2

Patch Set 1 #

Patch Set 2 : Make the default include logic more intuitive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pydir/szbuild.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
6 years, 2 months ago (2014-09-26 16:23:38 UTC) #2
jvoung (off chromium)
lgtm
6 years, 2 months ago (2014-09-26 16:41:57 UTC) #3
Jim Stichnoth
6 years, 2 months ago (2014-09-26 16:47:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as be22e14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698