pydir/szbuild.py - Issue 605283002: Subzero: Change szbuild.py to prefer Subzero by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/szbuild.py

Issue 605283002: Subzero: Change szbuild.py to prefer Subzero by default. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Make the default include logic more intuitive Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pydir/szbuild.py

diff --git a/pydir/szbuild.py b/pydir/szbuild.py

index ab67f027f7f024b205f02c2dabef032f0cad5f70..63d7db0f463e313c066c89cd5d3c3b699d99fd59 100755

--- a/pydir/szbuild.py

+++ b/pydir/szbuild.py

@@ -219,9 +219,9 @@ def ProcessPexe(args, pexe, exe):

re_include = re.compile(re_include_str)

re_exclude = re.compile(re_exclude_str)

# If a symbol doesn't explicitly match re_include or re_exclude,

- # the default MatchSymbol() result is False, unless some --exclude

- # args are provided and no --include args are provided.

- default_match = len(args.exclude) and not len(args.include)

+ # the default MatchSymbol() result is True, unless some --include

+ # args are provided.

+ default_match = not len(args.include)

whitelist_has_items = False

with open(whitelist_sz_unescaped, 'w') as f:

« no previous file with comments | « no previous file | no next file » | no next file with comments »