Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7206)

Unified Diff: chrome/chrome_tests.gypi

Issue 605243002: Explicitly depend on ICU to fix GPU isolate races. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 59bed22c9490513c022ef6935883227187c85166..bfe3e4c3a147fa14ce99f690f86dc4ca32378efb 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -2950,6 +2950,8 @@
'type': 'none',
'dependencies': [
'../gpu/gpu.gyp:angle_unittests',
+ # depend on icu to fix races. http://crbug.com/417583
+ '../third_party/icu/icu.gyp:icudata',
M-A Ruel 2014/09/26 17:01:19 In practice, a lower level common target should de
],
'includes': [
'../build/isolate.gypi',
@@ -2978,6 +2980,8 @@
'type': 'none',
'dependencies': [
'browser_tests_run',
+ # depend on icu to fix races. http://crbug.com/417583
+ '../third_party/icu/icu.gyp:icudata',
],
'includes': [
'../build/isolate.gypi',
@@ -2993,6 +2997,8 @@
'dependencies': [
'chrome_run',
'../tools/telemetry/telemetry.gyp:bitmaptools#host',
+ # depend on icu to fix races. http://crbug.com/417583
+ '../third_party/icu/icu.gyp:icudata',
],
'includes': [
'../build/isolate.gypi',
@@ -3007,6 +3013,8 @@
'type': 'none',
'dependencies': [
'../gpu/gpu.gyp:gpu_unittests',
+ # depend on icu to fix races. http://crbug.com/417583
+ '../third_party/icu/icu.gyp:icudata',
],
'includes': [
'../build/isolate.gypi',
@@ -3025,6 +3033,8 @@
'type': 'none',
'dependencies': [
'../gpu/gles2_conform_support/gles2_conform_test.gyp:gles2_conform_test',
+ # depend on icu to fix races. http://crbug.com/417583
+ '../third_party/icu/icu.gyp:icudata',
],
'includes': [
'../build/isolate.gypi',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698