Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/chrome_tests.gypi

Issue 605243002: Explicitly depend on ICU to fix GPU isolate races. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'includes': [ 5 'includes': [
6 'js_unittest_vars.gypi', 6 'js_unittest_vars.gypi',
7 ], 7 ],
8 'targets': [ 8 'targets': [
9 { 9 {
10 'target_name': 'interactive_ui_tests', 10 'target_name': 'interactive_ui_tests',
(...skipping 2932 matching lines...) Expand 10 before | Expand all | Expand 10 after
2943 }, 2943 },
2944 ], 2944 ],
2945 'conditions': [ 2945 'conditions': [
2946 ['archive_gpu_tests==1', { 2946 ['archive_gpu_tests==1', {
2947 'targets': [ 2947 'targets': [
2948 { 2948 {
2949 'target_name': 'angle_unittests_run', 2949 'target_name': 'angle_unittests_run',
2950 'type': 'none', 2950 'type': 'none',
2951 'dependencies': [ 2951 'dependencies': [
2952 '../gpu/gpu.gyp:angle_unittests', 2952 '../gpu/gpu.gyp:angle_unittests',
2953 # depend on icu to fix races. http://crbug.com/417583
2954 '../third_party/icu/icu.gyp:icudata',
M-A Ruel 2014/09/26 17:01:19 In practice, a lower level common target should de
2953 ], 2955 ],
2954 'includes': [ 2956 'includes': [
2955 '../build/isolate.gypi', 2957 '../build/isolate.gypi',
2956 'angle_unittests.isolate', 2958 'angle_unittests.isolate',
2957 ], 2959 ],
2958 'sources': [ 2960 'sources': [
2959 'angle_unittests.isolate', 2961 'angle_unittests.isolate',
2960 ], 2962 ],
2961 }, 2963 },
2962 { 2964 {
2963 'target_name': 'gl_tests_run', 2965 'target_name': 'gl_tests_run',
2964 'type': 'none', 2966 'type': 'none',
2965 'dependencies': [ 2967 'dependencies': [
2966 '../gpu/gpu.gyp:gl_tests', 2968 '../gpu/gpu.gyp:gl_tests',
2967 ], 2969 ],
2968 'includes': [ 2970 'includes': [
2969 '../build/isolate.gypi', 2971 '../build/isolate.gypi',
2970 'gl_tests.isolate', 2972 'gl_tests.isolate',
2971 ], 2973 ],
2972 'sources': [ 2974 'sources': [
2973 'gl_tests.isolate', 2975 'gl_tests.isolate',
2974 ], 2976 ],
2975 }, 2977 },
2976 { 2978 {
2977 'target_name': 'tab_capture_end2end_tests_run', 2979 'target_name': 'tab_capture_end2end_tests_run',
2978 'type': 'none', 2980 'type': 'none',
2979 'dependencies': [ 2981 'dependencies': [
2980 'browser_tests_run', 2982 'browser_tests_run',
2983 # depend on icu to fix races. http://crbug.com/417583
2984 '../third_party/icu/icu.gyp:icudata',
2981 ], 2985 ],
2982 'includes': [ 2986 'includes': [
2983 '../build/isolate.gypi', 2987 '../build/isolate.gypi',
2984 'tab_capture_end2end_tests.isolate', 2988 'tab_capture_end2end_tests.isolate',
2985 ], 2989 ],
2986 'sources': [ 2990 'sources': [
2987 'tab_capture_end2end_tests.isolate', 2991 'tab_capture_end2end_tests.isolate',
2988 ], 2992 ],
2989 }, 2993 },
2990 { 2994 {
2991 'target_name': 'telemetry_gpu_test_run', 2995 'target_name': 'telemetry_gpu_test_run',
2992 'type': 'none', 2996 'type': 'none',
2993 'dependencies': [ 2997 'dependencies': [
2994 'chrome_run', 2998 'chrome_run',
2995 '../tools/telemetry/telemetry.gyp:bitmaptools#host', 2999 '../tools/telemetry/telemetry.gyp:bitmaptools#host',
3000 # depend on icu to fix races. http://crbug.com/417583
3001 '../third_party/icu/icu.gyp:icudata',
2996 ], 3002 ],
2997 'includes': [ 3003 'includes': [
2998 '../build/isolate.gypi', 3004 '../build/isolate.gypi',
2999 'telemetry_gpu_test.isolate', 3005 'telemetry_gpu_test.isolate',
3000 ], 3006 ],
3001 'sources': [ 3007 'sources': [
3002 'telemetry_gpu_test.isolate', 3008 'telemetry_gpu_test.isolate',
3003 ], 3009 ],
3004 }, 3010 },
3005 { 3011 {
3006 'target_name': 'gpu_unittests_run', 3012 'target_name': 'gpu_unittests_run',
3007 'type': 'none', 3013 'type': 'none',
3008 'dependencies': [ 3014 'dependencies': [
3009 '../gpu/gpu.gyp:gpu_unittests', 3015 '../gpu/gpu.gyp:gpu_unittests',
3016 # depend on icu to fix races. http://crbug.com/417583
3017 '../third_party/icu/icu.gyp:icudata',
3010 ], 3018 ],
3011 'includes': [ 3019 'includes': [
3012 '../build/isolate.gypi', 3020 '../build/isolate.gypi',
3013 'gpu_unittests.isolate', 3021 'gpu_unittests.isolate',
3014 ], 3022 ],
3015 'sources': [ 3023 'sources': [
3016 'gpu_unittests.isolate', 3024 'gpu_unittests.isolate',
3017 ], 3025 ],
3018 }, 3026 },
3019 ], 3027 ],
3020 'conditions': [ 3028 'conditions': [
3021 ['internal_gles2_conform_tests==1', { 3029 ['internal_gles2_conform_tests==1', {
3022 'targets': [ 3030 'targets': [
3023 { 3031 {
3024 'target_name': 'gles2_conform_test_run', 3032 'target_name': 'gles2_conform_test_run',
3025 'type': 'none', 3033 'type': 'none',
3026 'dependencies': [ 3034 'dependencies': [
3027 '../gpu/gles2_conform_support/gles2_conform_test.gyp:gles2_c onform_test', 3035 '../gpu/gles2_conform_support/gles2_conform_test.gyp:gles2_c onform_test',
3036 # depend on icu to fix races. http://crbug.com/417583
3037 '../third_party/icu/icu.gyp:icudata',
3028 ], 3038 ],
3029 'includes': [ 3039 'includes': [
3030 '../build/isolate.gypi', 3040 '../build/isolate.gypi',
3031 'gles2_conform_test.isolate', 3041 'gles2_conform_test.isolate',
3032 ], 3042 ],
3033 'sources': [ 3043 'sources': [
3034 'gles2_conform_test.isolate', 3044 'gles2_conform_test.isolate',
3035 ], 3045 ],
3036 }, 3046 },
3037 ], 3047 ],
(...skipping 20 matching lines...) Expand all
3058 ['enable_webrtc==1', { 3068 ['enable_webrtc==1', {
3059 'dependencies': [ 3069 'dependencies': [
3060 '../third_party/libjingle/libjingle.gyp:libjingle_webrtc' 3070 '../third_party/libjingle/libjingle.gyp:libjingle_webrtc'
3061 ] 3071 ]
3062 }], 3072 }],
3063 ], 3073 ],
3064 }] 3074 }]
3065 }], 3075 }],
3066 ], # 'conditions' 3076 ], # 'conditions'
3067 } 3077 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698