content/browser/service_worker/service_worker_job_unittest.cc - Issue 605163002: Service Worker: Remove legacy code for resolving register() to a version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 605163002: Service Worker: Remove legacy code for resolving register() to a version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: only resolve on active_version Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_register_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc

index 8c29e8d8453b446520f3b56df60943b5697e3b74..976f5bdf59b23f14c536648c3051770ef258f6e7 100644

--- a/content/browser/service_worker/service_worker_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_job_unittest.cc

@@ -38,10 +38,7 @@ void SaveRegistrationCallback(

bool* called,

scoped_refptr<ServiceWorkerRegistration>* registration_out,

ServiceWorkerStatusCode status,

- ServiceWorkerRegistration* registration,

- ServiceWorkerVersion* version) {

- ASSERT_TRUE(!version || version->registration_id() == registration->id())

- << version << " " << registration;

+ ServiceWorkerRegistration* registration) {

EXPECT_EQ(expected_status, status);

*called = true;

*registration_out = registration;