content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 605163002: Service Worker: Remove legacy code for resolving register() to a version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 605163002: Service Worker: Remove legacy code for resolving register() to a version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: only resolve on active_version Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.h ('k') | content/browser/service_worker/service_worker_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index da7979b575e2a67efa4f607a45e7324a76f435ab..29017a4ce4dbb58774f2be5bab84ea6c74389ae9 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -477,8 +477,7 @@ void ServiceWorkerDispatcherHost::RegistrationComplete(

int provider_id,

int request_id,

ServiceWorkerStatusCode status,

- int64 registration_id,

- int64 version_id) {

+ int64 registration_id) {

if (!GetContext())

return;

@@ -498,11 +497,11 @@ void ServiceWorkerDispatcherHost::RegistrationComplete(

Send(new ServiceWorkerMsg_ServiceWorkerRegistered(

thread_id, request_id, info, attrs));

- TRACE_EVENT_ASYNC_END2("ServiceWorker",

+ TRACE_EVENT_ASYNC_END1("ServiceWorker",

"ServiceWorkerDispatcherHost::RegisterServiceWorker",

request_id,

- "Registration ID", registration_id,

- "Version ID", version_id);

+ "Registration ID",

+ registration_id);

}

void ServiceWorkerDispatcherHost::OnWorkerReadyForInspection(