chrome/test/chromedriver/chrome/version.h - Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/version.h

Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot to git add new files Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/navigation_tracker.cc ('K') | « chrome/test/chromedriver/chrome/stub_chrome.h ('k') | chrome/test/chromedriver/chrome/version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/version.h

diff --git a/chrome/test/chromedriver/chrome/version.h b/chrome/test/chromedriver/chrome/version.h

index 39ca4e9c99df1fb8b214bb97b08f5d7a9c0b1036..1618b97857645fe4319b0bd4fdb5e837c2684ebc 100644

--- a/chrome/test/chromedriver/chrome/version.h

+++ b/chrome/test/chromedriver/chrome/version.h

@@ -7,19 +7,6 @@

#include <string>

-struct BrowserInfo {

- BrowserInfo();

- BrowserInfo(std::string browser_name_,

- std::string browser_version_,

- int build_no_,

- int blink_revision_);

- std::string browser_name;

- std::string browser_version;

- int build_no;

- int blink_revision;

-};

extern const int kMinimumSupportedChromeBuildNo;

std::string GetMinimumSupportedChromeVersion();