Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2013)

Unified Diff: chrome/test/chromedriver/chrome/version.cc

Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot to git add new files Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/version.cc
diff --git a/chrome/test/chromedriver/chrome/version.cc b/chrome/test/chromedriver/chrome/version.cc
index 6caa660f64999d96aa2aef36a2b606ebf711dbea..3a5cca3ccaa6c6984aca6264a9defb6fa6260749 100644
--- a/chrome/test/chromedriver/chrome/version.cc
+++ b/chrome/test/chromedriver/chrome/version.cc
@@ -15,31 +15,6 @@ const int kMinimumSupportedChromeVersion[] = {35, 0, 1916, 0};
const int kMinimumSupportedChromeBuildNo = kMinimumSupportedChromeVersion[2];
-// Content Shell and WebView have an empty product version and a fake user
-// agent. There's no way to detect the actual version, so unless specified we
-// assume it is tip of tree.
-static const int kToTBuildNo = 9999;
-
-// Similarly, if the Blink Revision isn't given then assume it is tip of tree.
-static const int kToTBlinkRevision = 999999;
-
-BrowserInfo::BrowserInfo()
- : browser_name(std::string()),
- browser_version(std::string()),
- build_no(kToTBuildNo),
- blink_revision(kToTBlinkRevision) {
-}
-
-BrowserInfo::BrowserInfo(std::string browser_name,
- std::string browser_version,
- int build_no,
- int blink_revision)
- : browser_name(browser_name),
- browser_version(browser_version),
- build_no(build_no),
- blink_revision(blink_revision) {
-}
-
std::string GetMinimumSupportedChromeVersion() {
return base::StringPrintf(
"%d.%d.%d.%d",

Powered by Google App Engine
This is Rietveld 408576698