Issue 605133004: Let test driver fail if test executable can't list the tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 605133004: Let test driver fail if test executable can't list the tests. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach

Modified:
6 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, Benedikt Meurer, dcarney

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Let test driver fail if test executable can't list the tests. TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24253

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/testrunner/local/testsuite.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

PTAL. Note: This will fail all suites also if only one has a problem.

6 years, 2 months ago (2014-09-26 12:38:33 UTC) #2

Michael Achenbach

Committed patchset #1 (id:1) manually as 24253 (tree was closed).

6 years, 2 months ago (2014-09-26 13:46:32 UTC) #3

Jakob Kummerow

6 years, 2 months ago (2014-09-26 13:49:10 UTC) #4

Message was sent while issue was closed.

TBR is not for the impatient!

See one comment below. Also, the same change should be applied to cctest.

https://codereview.chromium.org/605133004/diff/1/tools/testrunner/local/tests...
File tools/testrunner/local/testsuite.py (right):

https://codereview.chromium.org/605133004/diff/1/tools/testrunner/local/tests...
tools/testrunner/local/testsuite.py:237: raise Exception("Test executable failed
to list the tests.")
You should print something to identify the suite (name/path/executable).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages