tools/testrunner/local/testsuite.py - Issue 605133004: Let test driver fail if test executable can't list the tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testrunner/local/testsuite.py

Issue 605133004: Let test driver fail if test executable can't list the tests. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testrunner/local/testsuite.py

diff --git a/tools/testrunner/local/testsuite.py b/tools/testrunner/local/testsuite.py

index 47bc08f8399767343e02dee5fa285868e8e783a8..148697bfde7506e630baf53105dd06b59e7e5628 100644

--- a/tools/testrunner/local/testsuite.py

+++ b/tools/testrunner/local/testsuite.py

@@ -234,7 +234,7 @@ class GoogleTestSuite(TestSuite):

if output.exit_code != 0:

print output.stdout

print output.stderr

- return []

+ raise Exception("Test executable failed to list the tests.")

Jakob Kummerow 2014/09/26 13:49:10 You should print something to identify the suite (

tests = []

test_case = ''

for line in output.stdout.splitlines():

« no previous file with comments | « no previous file | no next file » | no next file with comments »