Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 60513013: Start on GM to verify removal of 32767 limit in SkBlurMaskFilter::filterRectsToNine is okay (Closed)

Created:
7 years, 1 month ago by robertphillips
Modified:
7 years, 1 month ago
Reviewers:
tomhudson, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

In investigating issue 1805 (Skia Debugger crashes when profiling SkPicture from chrome - https://code.google.com/p/skia/issues/detail?id=1805) it was revealed that Skia bails out of the blur rect fast path if the rect to be blurred is larger than 32767. It seems that the nine patch path should be able to handle that case. This CL attempts to prove that.

Patch Set 1 #

Patch Set 2 : Ready for review #

Total comments: 1

Patch Set 3 : Hopefully clarified values & offsets #

Patch Set 4 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -1 line) Patch
A gm/bigblurs.cpp View 1 2 3 1 chunk +117 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
Not ready for review yet. It isn't testing the cases when x or y are ...
7 years, 1 month ago (2013-11-06 21:03:07 UTC) #1
robertphillips
PTAL https://codereview.chromium.org/60513013/diff/40001/src/effects/SkBlurMaskFilter.cpp File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/60513013/diff/40001/src/effects/SkBlurMaskFilter.cpp#newcode217 src/effects/SkBlurMaskFilter.cpp:217: if (SkBlurMaskFilter::kInner_BlurStyle == fBlurStyle || Turns out the ...
7 years, 1 month ago (2013-11-07 15:39:48 UTC) #2
Tom Hudson
Hard to validate all that math in the expressions for origins[]. (Do we really want ...
7 years, 1 month ago (2013-11-07 15:50:06 UTC) #3
robertphillips
PTAL.
7 years, 1 month ago (2013-11-07 20:25:59 UTC) #4
reed1
lgtm
7 years, 1 month ago (2013-11-07 20:40:11 UTC) #5
robertphillips
7 years, 1 month ago (2013-11-07 22:25:43 UTC) #6
Message was sent while issue was closed.
committed as r12181

Powered by Google App Engine
This is Rietveld 408576698