Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: src/effects/SkBlurMaskFilter.cpp

Issue 60513013: Start on GM to verify removal of 32767 limit in SkBlurMaskFilter::filterRectsToNine is okay (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Clean up Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « gyp/gmslides.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2006 The Android Open Source Project 3 * Copyright 2006 The Android Open Source Project
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 #include "SkBlurMaskFilter.h" 9 #include "SkBlurMaskFilter.h"
10 #include "SkBlurMask.h" 10 #include "SkBlurMask.h"
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 SkBlurMaskFilterImpl::filterRectsToNine(const SkRect rects[], int count, 207 SkBlurMaskFilterImpl::filterRectsToNine(const SkRect rects[], int count,
208 const SkMatrix& matrix, 208 const SkMatrix& matrix,
209 const SkIRect& clipBounds, 209 const SkIRect& clipBounds,
210 NinePatch* patch) const { 210 NinePatch* patch) const {
211 if (count < 1 || count > 2) { 211 if (count < 1 || count > 2) {
212 return kUnimplemented_FilterReturn; 212 return kUnimplemented_FilterReturn;
213 } 213 }
214 214
215 // TODO: report correct metrics for innerstyle, where we do not grow the 215 // TODO: report correct metrics for innerstyle, where we do not grow the
216 // total bounds, but we do need an inset the size of our blur-radius 216 // total bounds, but we do need an inset the size of our blur-radius
217 if (SkBlurMaskFilter::kInner_BlurStyle == fBlurStyle) { 217 if (SkBlurMaskFilter::kInner_BlurStyle == fBlurStyle ||
218 SkBlurMaskFilter::kOuter_BlurStyle == fBlurStyle) {
218 return kUnimplemented_FilterReturn; 219 return kUnimplemented_FilterReturn;
219 } 220 }
220 221
221 // TODO: take clipBounds into account to limit our coordinates up front 222 // TODO: take clipBounds into account to limit our coordinates up front
222 // for now, just skip too-large src rects (to take the old code path). 223 // for now, just skip too-large src rects (to take the old code path).
223 if (rect_exceeds(rects[0], SkIntToScalar(32767))) { 224 if (rect_exceeds(rects[0], SkIntToScalar(32767))) {
224 return kUnimplemented_FilterReturn; 225 return kUnimplemented_FilterReturn;
225 } 226 }
226 227
227 SkIPoint margin; 228 SkIPoint margin;
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 } else { 474 } else {
474 str->append("None"); 475 str->append("None");
475 } 476 }
476 str->append("))"); 477 str->append("))");
477 } 478 }
478 #endif 479 #endif
479 480
480 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkBlurMaskFilter) 481 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkBlurMaskFilter)
481 SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkBlurMaskFilterImpl) 482 SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkBlurMaskFilterImpl)
482 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END 483 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END
OLDNEW
« no previous file with comments | « gyp/gmslides.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698