Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: tools/testing/dart/launch_browser.dart

Issue 60503002: Add browser path options to testing scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Change switch statement and chained if statements to map lookups Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/browser_controller.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/launch_browser.dart
diff --git a/tools/testing/dart/launch_browser.dart b/tools/testing/dart/launch_browser.dart
index 3637906cda56cd5375ef0505424a9102738aad7b..047182fa29bc9f80efb2ace998fc13543a1739da 100644
--- a/tools/testing/dart/launch_browser.dart
+++ b/tools/testing/dart/launch_browser.dart
@@ -26,14 +26,15 @@ void main() {
printHelp();
return;
}
+ var name = args[0];
- if (!Browser.supportedBrowser(args[0])) {
+ if (!Browser.supportedBrowser(name)) {
print("Specified browser not supported");
printHelp();
return;
}
- var browser = new Browser.byName(args[0]);
+ var executable = Locations.getBrowserExecutable(name, {});
+ var browser = new Browser.byName(name, executable);
browser.start(args[1]);
-
}
« no previous file with comments | « tools/testing/dart/browser_controller.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698