Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/testing/dart/test_options.dart

Issue 60503002: Add browser path options to testing scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Change switch statement and chained if statements to map lookups Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/launch_browser.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index b1528ec5525348940792c03500bbbf3bdcda3c25..bc183c503169201572db77e79545295fd92e6ead 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -243,6 +243,24 @@ class TestOptionsParser {
[],
''),
new _TestOptionSpecification(
+ 'firefox',
+ 'Path to firefox browser executable',
+ ['--firefox'],
+ [],
+ ''),
+ new _TestOptionSpecification(
+ 'chrome',
+ 'Path to chrome browser executable',
+ ['--chrome'],
+ [],
+ ''),
+ new _TestOptionSpecification(
+ 'safari',
+ 'Path to safari browser executable',
+ ['--safari'],
+ [],
+ ''),
+ new _TestOptionSpecification(
'use_sdk',
'''Use compiler or runtime from the SDK.
@@ -484,8 +502,8 @@ Note: currently only implemented for dart2js.''',
// options.
Set<String> _blacklistedOptions = new Set<String>.from([
'progress', 'failure-summary', 'step_name', 'report', 'tasks', 'verbose',
- 'time', 'dart', 'drt', 'dartium', 'build_directory', 'append_logs',
- 'local_ip', 'shard', 'shards',
+ 'time', 'dart', 'drt', 'dartium', 'firefox', 'chrome', 'safari',
+ 'build_directory', 'append_logs', 'local_ip', 'shard', 'shards',
]);
List<String> _constructReproducingCommandArguments(Map config) {
« no previous file with comments | « tools/testing/dart/launch_browser.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698