Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 604843002: Replace OVERRIDE and FINAL with their C++11 counterparts in WTF (Closed)

Created:
6 years, 2 months ago by Mikhail
Modified:
6 years, 2 months ago
Reviewers:
Nico
CC:
blink-reviews, aandrey+blink_chromium.org, mkwst+moarreviews_chromium.org, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium, eseidel, Nico, dcheng, Avi (use Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with their C++11 counterparts in WTF A search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. The 'OVERRIDE' and 'FINAL' macros are still present until all the client code is modified. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182747

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep the mechanical part only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -99 lines) Patch
M Source/wtf/FilePrintStream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/wtf/Float32Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Float64Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Functional.h View 49 chunks +56 lines, -56 lines 0 comments Download
M Source/wtf/Int16Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Int32Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Int8Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/TypedArrayBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Uint16Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Uint32Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Uint8Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Uint8ClampedArray.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/text/TextCodecICU.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/wtf/text/TextCodecLatin1.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/wtf/text/TextCodecReplacement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/text/TextCodecUTF16.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/wtf/text/TextCodecUTF8.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/text/TextCodecUserDefined.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mikhail
The CL with global rename was too big to be upload, so this CL touches ...
6 years, 2 months ago (2014-09-25 14:20:07 UTC) #1
Nico
lgtm https://codereview.chromium.org/604843002/diff/1/Source/wtf/Compiler.h File Source/wtf/Compiler.h (left): https://codereview.chromium.org/604843002/diff/1/Source/wtf/Compiler.h#oldcode216 Source/wtf/Compiler.h:216: #define FINAL nit: This seems kind of independent ...
6 years, 2 months ago (2014-09-25 19:32:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604843002/20001
6 years, 2 months ago (2014-09-26 08:24:15 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 09:35:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182747

Powered by Google App Engine
This is Rietveld 408576698