VideoCapture: Remove deep frame copy in the border to libJingle

content/renderer/media/webrtc/webrtc_video_capturer_adapter.h

Index: content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
diff --git a/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h b/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
index 52245526d3b6fd0e8edf4295dfa910c7cd39ed98..ed80edefc0ee703f76b333c373b1274ef16c8afc 100644
--- a/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
+++ b/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
@@ -16,6 +16,9 @@
 #include "third_party/libjingle/source/talk/media/base/videocapturer.h"
 
 namespace content {
+namespace {

[perkj_chrome, 2014/10/16 13:47:31]

not compatible with the style guide.

https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...

I would say, make this a private class inside WebRtcVideoCapturerAdapter. 
Otherwise you will have to put it inside the conent ns and give it a  name that
indicates its only meaningfull in the scope of WebRtcVideoCapturerAdapter.

[magjed_chromium, 2014/10/16 14:39:59]

Done.

+class MediaVideoFrameFactory;
+}
 
 // WebRtcVideoCapturerAdapter implements a simple cricket::VideoCapturer that is
 // used for VideoCapturing in libJingle and especially in PeerConnections.
@@ -48,19 +51,16 @@ class CONTENT_EXPORT WebRtcVideoCapturerAdapter
                                     cricket::VideoFormat* best_format) override;
   virtual bool IsScreencast() const override;
 
-  void UpdateI420Buffer(const scoped_refptr<media::VideoFrame>& src);
-
   // |thread_checker_| is bound to the libjingle worker thread.
   base::ThreadChecker thread_checker_;
 
   const bool is_screencast_;
   bool running_;
   base::TimeDelta first_frame_timestamp_;
-  // |buffer_| used if cropping is needed. It is created only if needed and
-  // owned by WebRtcVideoCapturerAdapter. If its created, it exists until
-  // WebRtcVideoCapturerAdapter is destroyed.
-  uint8* buffer_;
-  size_t buffer_size_;
+
+  // This is an alias to the frame_factory_ in the base class
+  // cricket::VideoCapturer.
+  MediaVideoFrameFactory* frame_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebRtcVideoCapturerAdapter);
 };