VideoCapture: Remove deep frame copy in the border to libJingle

content/renderer/media/webrtc/webrtc_video_capturer_adapter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_WEBRTC_WEBRTC_VIDEO_CAPTURER_ADAPTER_H_
 #define CONTENT_RENDERER_MEDIA_WEBRTC_WEBRTC_VIDEO_CAPTURER_ADAPTER_H_
 
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/threading/thread_checker.h"
 #include "content/common/content_export.h"
 #include "media/base/video_frame.h"
 #include "media/video/capture/video_capture_types.h"
 #include "third_party/libjingle/source/talk/media/base/videocapturer.h"
 
 namespace content {
+namespace {

[perkj_chrome, 2014/10/16 13:47:31]

not compatible with the style guide.

https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...

I would say, make this a private class inside WebRtcVideoCapturerAdapter. 
Otherwise you will have to put it inside the conent ns and give it a  name that
indicates its only meaningfull in the scope of WebRtcVideoCapturerAdapter.

[magjed_chromium, 2014/10/16 14:39:59]

Done.

+class MediaVideoFrameFactory;
+}
 
 // WebRtcVideoCapturerAdapter implements a simple cricket::VideoCapturer that is
 // used for VideoCapturing in libJingle and especially in PeerConnections.
 // The class is created and destroyed on the main render thread.
 // PeerConnection access cricket::VideoCapturer from a libJingle worker thread.
 // An instance of WebRtcVideoCapturerAdapter is owned by an instance of
 // webrtc::VideoSourceInterface in libJingle. The implementation of
 // webrtc::VideoSourceInterface guarantees that this object is not deleted
 // while it is still used in libJingle.
 class CONTENT_EXPORT WebRtcVideoCapturerAdapter
@@ skipping 12 matching lines @@
   // These methods are accessed from a libJingle worker thread.
   virtual cricket::CaptureState Start(
       const cricket::VideoFormat& capture_format) override;
   virtual void Stop() override;
   virtual bool IsRunning() override;
   virtual bool GetPreferredFourccs(std::vector<uint32>* fourccs) override;
   virtual bool GetBestCaptureFormat(const cricket::VideoFormat& desired,
                                     cricket::VideoFormat* best_format) override;
   virtual bool IsScreencast() const override;
 
-  void UpdateI420Buffer(const scoped_refptr<media::VideoFrame>& src);
-
   // |thread_checker_| is bound to the libjingle worker thread.
   base::ThreadChecker thread_checker_;
 
   const bool is_screencast_;
   bool running_;
   base::TimeDelta first_frame_timestamp_;
-  // |buffer_| used if cropping is needed. It is created only if needed and
-  // owned by WebRtcVideoCapturerAdapter. If its created, it exists until
-  // WebRtcVideoCapturerAdapter is destroyed.
-  uint8* buffer_;
-  size_t buffer_size_;
+
+  // This is an alias to the frame_factory_ in the base class
+  // cricket::VideoCapturer.
+  MediaVideoFrameFactory* frame_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebRtcVideoCapturerAdapter);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_WEBRTC_WEBRTC_VIDEO_CAPTURER_ADAPTER_H_