VideoCapture: Remove deep frame copy in the border to libJingle

media/base/video_frame.h

Index: media/base/video_frame.h
diff --git a/media/base/video_frame.h b/media/base/video_frame.h
index 928550cbd0724b2624f164970d8763e81f9207e6..a9940fdc9bdc30e02aa3bc02a6a97c93e61c1605 100644
--- a/media/base/video_frame.h
+++ b/media/base/video_frame.h
@@ -267,6 +267,10 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> {
   // VideoFrame object and must not be freed by the caller.
   uint8* data(size_t plane) const;
 
+  // Returns pointer to the visible region specified by visible_rect(). The
+  // memory is owned by VideoFrame object and must not be freed by the caller.
+  uint8* visible_data(size_t plane) const;

[tommi (sloooow) - chröme, 2014/09/25 20:06:48]

const method returning a pointer to a non-const buffer tends to go against
chromium code in general

[magjed_chromium, 2014/09/25 20:52:08]

Yes, agree. I followed the convention in this file for uint8* data(size_t plane)
const. I guess we should change to
const uint8* data(size_t plane) const;
uint8* data(size_t plane);
const uint8* visible_data(size_t plane) const;
uint8* visible_data(size_t plane);

+
   // Returns the mailbox holder of the native texture wrapped by this frame.
   // Only valid to call if this is a NATIVE_TEXTURE frame. Before using the
   // mailbox, the caller must wait for the included sync point.