VideoCapture: Remove deep frame copy in the border to libJingle

media/base/video_frame.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_VIDEO_FRAME_H_
 #define MEDIA_BASE_VIDEO_FRAME_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 249 matching lines @@
   //
   // As opposed to stride(), row_bytes() refers to the bytes representing
   // frame data scanlines (coded_size.width() pixels, without stride padding).
   int row_bytes(size_t plane) const;
   int rows(size_t plane) const;
 
   // Returns pointer to the buffer for a given plane. The memory is owned by
   // VideoFrame object and must not be freed by the caller.
   uint8* data(size_t plane) const;
 
+  // Returns pointer to the visible region specified by visible_rect(). The
+  // memory is owned by VideoFrame object and must not be freed by the caller.
+  uint8* visible_data(size_t plane) const;

[tommi (sloooow) - chröme, 2014/09/25 20:06:48]

const method returning a pointer to a non-const buffer tends to go against
chromium code in general

[magjed_chromium, 2014/09/25 20:52:08]

Yes, agree. I followed the convention in this file for uint8* data(size_t plane)
const. I guess we should change to
const uint8* data(size_t plane) const;
uint8* data(size_t plane);
const uint8* visible_data(size_t plane) const;
uint8* visible_data(size_t plane);

+
   // Returns the mailbox holder of the native texture wrapped by this frame.
   // Only valid to call if this is a NATIVE_TEXTURE frame. Before using the
   // mailbox, the caller must wait for the included sync point.
   const gpu::MailboxHolder* mailbox_holder() const;
 
   // Returns the shared-memory handle, if present
   base::SharedMemoryHandle shared_memory_handle() const;
 
 #if defined(OS_POSIX)
   // Returns backing dmabuf file descriptor for given |plane|, if present.
@@ skipping 109 matching lines @@
   uint32 release_sync_point_;
 
   const bool end_of_stream_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(VideoFrame);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_VIDEO_FRAME_H_