Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 604723002: Conversion of Date is trivial (Closed)

Created:
6 years, 2 months ago by Jens Widell
Modified:
6 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Conversion of Date is trivial Date values are converted using toCoreDate() in V8Bindings.h, which specifically handles native Date objects and numbers, converting each in a trivial way, and returning NaN for all other values. Note: WebIDL actually only allows Date objects, so toCoreDate() supports too much and would thus be even more trivial if it was to be adjusted to fully match the specification. BUG=413257 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
6 years, 2 months ago (2014-09-25 08:59:07 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-09-25 08:59:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604723002/1
6 years, 2 months ago (2014-09-25 09:10:34 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 10:22:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182668

Powered by Google App Engine
This is Rietveld 408576698