Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 604723002: Conversion of Date is trivial (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp
index a3237aa8389b489f3dcb488571288feda3f9a885..46a733e73d75d05d068479884a03b792354411ce 100644
--- a/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -192,7 +192,7 @@ static void dateAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v8:
{
v8::Handle<v8::Object> holder = info.Holder();
TestObject* impl = V8TestObject::toImpl(holder);
- TONATIVE_VOID(double, cppValue, toCoreDate(v8Value));
+ double cppValue = toCoreDate(v8Value);
impl->setDateAttribute(cppValue);
}
@@ -5203,9 +5203,7 @@ static void voidMethodDateArgMethod(const v8::FunctionCallbackInfo<v8::Value>& i
TestObject* impl = V8TestObject::toImpl(info.Holder());
double dateArg;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
- TONATIVE_VOID_INTERNAL(dateArg, toCoreDate(info[0]));
+ dateArg = toCoreDate(info[0]);
}
impl->voidMethodDateArg(dateArg);
}
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698