Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 604703004: Move string-related runtime functions into separate files. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move string-related runtime functions into separate files. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2913 lines, -3162 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime.cc View 14 chunks +74 lines, -2793 lines 0 comments Download
A src/runtime/runtime-json.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A src/runtime/runtime-regexp.cc View 1 chunk +1131 lines, -0 lines 0 comments Download
A src/runtime/runtime-strings.cc View 1 chunk +1252 lines, -0 lines 0 comments Download
A + src/runtime/runtime-uri.cc View 11 chunks +96 lines, -77 lines 0 comments Download
A src/runtime/string-builder.h View 1 chunk +296 lines, -0 lines 0 comments Download
D src/uri.h View 1 chunk +0 lines, -290 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-09-25 09:20:37 UTC) #1
Benedikt Meurer
LGTM (rubber-stamped)
6 years, 2 months ago (2014-09-25 09:21:33 UTC) #2
Yang
6 years, 2 months ago (2014-09-29 07:08:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24261 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698