Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 604563003: [Password Manager] Disable autofilling for testing password websites (Closed)

Created:
6 years, 2 months ago by Garrett Casto
Modified:
6 years, 2 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Disable autofilling for testing password websites BUG=415166 Committed: https://crrev.com/b39df3c9c6f25512ddfa25dd3d73353b09efe075 Cr-Commit-Position: refs/heads/master@{#296830}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 2 chunks +6 lines, -2 lines 2 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Garrett Casto
6 years, 2 months ago (2014-09-24 21:12:19 UTC) #2
vabr (Chromium)
LGTM
6 years, 2 months ago (2014-09-25 08:12:25 UTC) #3
Mike West
https://codereview.chromium.org/604563003/diff/1/chrome/browser/password_manager/chrome_password_manager_client.cc File chrome/browser/password_manager/chrome_password_manager_client.cc (right): https://codereview.chromium.org/604563003/diff/1/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode486 chrome/browser/password_manager/chrome_password_manager_client.cc:486: ("passwords(-([a-z]+\\.corp))?\\.google\\.com")); Only google.com? Or do we need to account ...
6 years, 2 months ago (2014-09-25 08:26:19 UTC) #5
Garrett Casto
https://codereview.chromium.org/604563003/diff/1/chrome/browser/password_manager/chrome_password_manager_client.cc File chrome/browser/password_manager/chrome_password_manager_client.cc (right): https://codereview.chromium.org/604563003/diff/1/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode486 chrome/browser/password_manager/chrome_password_manager_client.cc:486: ("passwords(-([a-z]+\\.corp))?\\.google\\.com")); On 2014/09/25 08:26:19, Mike West wrote: > Only ...
6 years, 2 months ago (2014-09-25 22:17:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604563003/1
6 years, 2 months ago (2014-09-25 22:18:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 08b4eff23664d919a99212488ce4ac2d1692a777
6 years, 2 months ago (2014-09-25 23:37:55 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:38:41 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b39df3c9c6f25512ddfa25dd3d73353b09efe075
Cr-Commit-Position: refs/heads/master@{#296830}

Powered by Google App Engine
This is Rietveld 408576698