Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 604563003: [Password Manager] Disable autofilling for testing password websites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
index 4f0b705fee585df002bd1f65e213cd162a06fed9..f04d0b96beeda0b159345208b1e48481239598e5 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
@@ -298,6 +298,12 @@ TEST_F(ChromePasswordManagerClientTest,
"https://passwords.%67oogle.com/settings&rart=123"));
EXPECT_FALSE(client->IsPasswordManagerEnabledForCurrentPage());
+ // Make sure testing sites are disabled as well.
+ NavigateAndCommit(
+ GURL("https://accounts.google.com/Login?continue="
+ "https://passwords-testing.corp.google.com/settings&rart=456"));
+ EXPECT_FALSE(client->IsPasswordManagerEnabledForCurrentPage());
+
// Fully qualified domain name is considered a different hostname by GURL.
// Ideally this would not be the case, but this quirk can be avoided by
// verification on the server. This test is simply documentation of this

Powered by Google App Engine
This is Rietveld 408576698