Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 604513002: [NaCl SDK] nacl_io: Add chmod/fchmod (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 2 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Add chmod/fchmod This change includes implementation for MemFs and FuseFs. I've also reordered the fuse_operations struct to match the order used in the real FUSE implementation. BUG=414793 R=sbc@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a4ef3a9c60553b3bcc8708587ea7832fc7cac29e

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -86 lines) Patch
M native_client_sdk/src/libraries/nacl_io/dir_node.h View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/dir_node.cc View 1 chunk +6 lines, -0 lines 2 comments Download
M native_client_sdk/src/libraries/nacl_io/fuse.h View 3 chunks +78 lines, -61 lines 2 comments Download
M native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs.h View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.h View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/node.h View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/node.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc View 5 chunks +62 lines, -21 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/mem_fs_node_test.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/mock_kernel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
6 years, 3 months ago (2014-09-24 20:07:18 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/604513002/diff/1/native_client_sdk/src/libraries/nacl_io/dir_node.cc File native_client_sdk/src/libraries/nacl_io/dir_node.cc (right): https://codereview.chromium.org/604513002/diff/1/native_client_sdk/src/libraries/nacl_io/dir_node.cc#newcode75 native_client_sdk/src/libraries/nacl_io/dir_node.cc:75: return 0; Could we not just put this ...
6 years, 3 months ago (2014-09-24 20:48:28 UTC) #2
binji
https://codereview.chromium.org/604513002/diff/1/native_client_sdk/src/libraries/nacl_io/dir_node.cc File native_client_sdk/src/libraries/nacl_io/dir_node.cc (right): https://codereview.chromium.org/604513002/diff/1/native_client_sdk/src/libraries/nacl_io/dir_node.cc#newcode75 native_client_sdk/src/libraries/nacl_io/dir_node.cc:75: return 0; On 2014/09/24 20:48:28, Sam Clegg wrote: > ...
6 years, 3 months ago (2014-09-24 21:30:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4ef3a9c60553b3bcc8708587ea7832fc7cac29e Cr-Commit-Position: refs/heads/master@{#296588}
6 years, 2 months ago (2014-09-25 00:16:38 UTC) #4
binji
6 years, 2 months ago (2014-09-25 00:46:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as a4ef3a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698