Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 604463004: Remove default args to several PageWidgetDelegate members, try 2. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
kenrb, Nate Chapin
CC:
blink-reviews, mkwst+moarreviews_chromium.org, site-isolation-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove default args to several PageWidgetDelegate members, try 2. BUG=411993 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182737

Patch Set 1 #

Patch Set 2 : Add a NULL check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -51 lines) Patch
M Source/web/PageWidgetDelegate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 4 chunks +21 lines, -39 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
The temporary check that the main frame is a local root is needed to keep ...
6 years, 2 months ago (2014-09-25 22:57:11 UTC) #2
Nate Chapin
lgtm
6 years, 2 months ago (2014-09-25 23:02:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604463004/20001
6 years, 2 months ago (2014-09-26 06:24:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 182737
6 years, 2 months ago (2014-09-26 06:35:19 UTC) #6
kenrb
On 2014/09/25 22:57:11, dcheng wrote: > The temporary check that the main frame is a ...
6 years, 2 months ago (2014-09-26 14:06:20 UTC) #7
dcheng
6 years, 2 months ago (2014-09-30 00:04:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/598503003/ by dcheng@chromium.org.

The reason for reverting is: Causing crashes on canary..

Powered by Google App Engine
This is Rietveld 408576698