Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 604463003: Changes NineImagePainter to snap to (enclosed) pixel boundaries (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 2 months ago
Reviewers:
ananta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changes NineImagePainter to snap to (enclosed) pixel boundaries Otherwise the sides may be clipped out. BUG=417493 TEST=see bug R=ananta@chromium.org Committed: https://crrev.com/d1ab0241ee29c70bd08531d1f038964664b124b6 Cr-Commit-Position: refs/heads/master@{#296608} Committed: https://crrev.com/005605e3c7d03316083c7017c93e8428ed5942de Cr-Commit-Position: refs/heads/master@{#297891}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 2

Patch Set 3 : merge to trunk #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M ui/gfx/canvas.cc View 1 4 chunks +9 lines, -10 lines 0 comments Download
M ui/gfx/nine_image_painter.cc View 1 2 3 3 chunks +29 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
sky
6 years, 3 months ago (2014-09-24 23:17:12 UTC) #1
ananta
https://codereview.chromium.org/604463003/diff/20001/ui/gfx/nine_image_painter.cc File ui/gfx/nine_image_painter.cc (right): https://codereview.chromium.org/604463003/diff/20001/ui/gfx/nine_image_painter.cc#newcode120 ui/gfx/nine_image_painter.cc:120: canvas->sk_canvas()->setMatrix(matrix); Will this be restored by ScopedCanvas when it ...
6 years, 3 months ago (2014-09-24 23:38:18 UTC) #2
sky
https://codereview.chromium.org/604463003/diff/20001/ui/gfx/nine_image_painter.cc File ui/gfx/nine_image_painter.cc (right): https://codereview.chromium.org/604463003/diff/20001/ui/gfx/nine_image_painter.cc#newcode120 ui/gfx/nine_image_painter.cc:120: canvas->sk_canvas()->setMatrix(matrix); On 2014/09/24 23:38:18, ananta wrote: > Will this ...
6 years, 3 months ago (2014-09-24 23:41:00 UTC) #3
ananta
lgtm
6 years, 3 months ago (2014-09-24 23:45:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604463003/20001
6 years, 3 months ago (2014-09-24 23:51:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0c7f6095cb5ea5073e13709d38f08013851792ae
6 years, 2 months ago (2014-09-25 01:21:31 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d1ab0241ee29c70bd08531d1f038964664b124b6 Cr-Commit-Position: refs/heads/master@{#296608}
6 years, 2 months ago (2014-09-25 01:22:11 UTC) #8
sky
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/605893002/ by sky@chromium.org. ...
6 years, 2 months ago (2014-09-26 00:08:11 UTC) #9
sky
Ok, I've reopenned this and fixed the bugs that were uncovered. There were two issues ...
6 years, 2 months ago (2014-09-30 22:14:54 UTC) #10
ananta
lgtm
6 years, 2 months ago (2014-10-02 18:41:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604463003/60001
6 years, 2 months ago (2014-10-02 19:13:48 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 14b3b4850fa7fc41337dc081c712812a8b98d68d
6 years, 2 months ago (2014-10-02 20:35:20 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:35:56 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/005605e3c7d03316083c7017c93e8428ed5942de
Cr-Commit-Position: refs/heads/master@{#297891}

Powered by Google App Engine
This is Rietveld 408576698