Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 604443003: Adds more webview tests to app_shell_browsertests. (Closed)

Created:
6 years, 3 months ago by lfg
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Xi Han, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds more webview tests to app_shell_browsertests. This CL adds a few more tests to app_shell_browsertests: WebViewAPITest.TestAllowTransparencyAttribute WebViewAPITest.TestAutosizeAfterNavigation WebViewAPITest.TestAutosizeBeforeNavigation WebViewAPITest.TestAutosizeHeight WebViewAPITest.TestAutosizeRemoveAttributes WebViewAPITest.TestAutosizeWithPartialAttributes BUG=352293 Committed: https://crrev.com/78312f3a06b6b2a2b7d3118120881257907ab31b Cr-Commit-Position: refs/heads/master@{#296570}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : include guards #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -172 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 2 3 4 chunks +6 lines, -82 lines 0 comments Download
A extensions/browser/guest_view/web_view/test_guest_view_manager.h View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
A extensions/browser/guest_view/web_view/test_guest_view_manager.cc View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 2 3 4 chunks +27 lines, -89 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 2 chunks +255 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
lfg
6 years, 3 months ago (2014-09-24 18:38:12 UTC) #2
Fady Samuel
Awesome! Factoring out code into a common file is great! LGTM
6 years, 3 months ago (2014-09-24 20:49:04 UTC) #3
Fady Samuel
https://codereview.chromium.org/604443003/diff/20001/extensions/browser/guest_view/web_view/web_view_test_common.h File extensions/browser/guest_view/web_view/web_view_test_common.h (right): https://codereview.chromium.org/604443003/diff/20001/extensions/browser/guest_view/web_view/web_view_test_common.h#newcode1 extensions/browser/guest_view/web_view/web_view_test_common.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 3 months ago (2014-09-24 20:50:12 UTC) #4
lfg
yoz@chromium.org: Please review changes in extensions/*
6 years, 2 months ago (2014-09-24 21:12:23 UTC) #6
Yoyo Zhou
LGTM https://codereview.chromium.org/604443003/diff/40001/extensions/browser/guest_view/web_view/web_view_test_common.h File extensions/browser/guest_view/web_view/web_view_test_common.h (right): https://codereview.chromium.org/604443003/diff/40001/extensions/browser/guest_view/web_view/web_view_test_common.h#newcode5 extensions/browser/guest_view/web_view/web_view_test_common.h:5: #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_TEST_COMMON_H_ Why not call this test_guest_view_manager.h?
6 years, 2 months ago (2014-09-24 21:55:06 UTC) #7
lfg
https://codereview.chromium.org/604443003/diff/40001/extensions/browser/guest_view/web_view/web_view_test_common.h File extensions/browser/guest_view/web_view/web_view_test_common.h (right): https://codereview.chromium.org/604443003/diff/40001/extensions/browser/guest_view/web_view/web_view_test_common.h#newcode5 extensions/browser/guest_view/web_view/web_view_test_common.h:5: #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_TEST_COMMON_H_ On 2014/09/24 21:55:06, Yoyo Zhou wrote: > ...
6 years, 2 months ago (2014-09-24 22:17:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604443003/60001
6 years, 2 months ago (2014-09-24 23:05:55 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 886a43d2f4bed9675be5152e56a94d51f999a72b
6 years, 2 months ago (2014-09-24 23:42:20 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 23:47:17 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/78312f3a06b6b2a2b7d3118120881257907ab31b
Cr-Commit-Position: refs/heads/master@{#296570}

Powered by Google App Engine
This is Rietveld 408576698