Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 604443003: Adds more webview tests to app_shell_browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/path_service.h" 5 #include "base/path_service.h"
6 #include "base/strings/stringprintf.h" 6 #include "base/strings/stringprintf.h"
7 #include "content/public/test/browser_test_utils.h" 7 #include "content/public/test/browser_test_utils.h"
8 #include "content/public/test/test_utils.h" 8 #include "content/public/test/test_utils.h"
9 #include "extensions/browser/app_window/app_window.h" 9 #include "extensions/browser/app_window/app_window.h"
10 #include "extensions/browser/app_window/app_window_registry.h" 10 #include "extensions/browser/app_window/app_window_registry.h"
11 #include "extensions/browser/extension_host.h" 11 #include "extensions/browser/extension_host.h"
12 #include "extensions/browser/guest_view/guest_view_manager.h" 12 #include "extensions/browser/guest_view/guest_view_manager.h"
13 #include "extensions/browser/guest_view/guest_view_manager_factory.h" 13 #include "extensions/browser/guest_view/guest_view_manager_factory.h"
14 #include "extensions/browser/guest_view/web_view/test_guest_view_manager.h"
14 #include "extensions/browser/process_manager.h" 15 #include "extensions/browser/process_manager.h"
15 #include "extensions/common/extension.h" 16 #include "extensions/common/extension.h"
16 #include "extensions/common/extension_paths.h" 17 #include "extensions/common/extension_paths.h"
17 #include "extensions/shell/browser/shell_extension_system.h" 18 #include "extensions/shell/browser/shell_extension_system.h"
18 #include "extensions/shell/test/shell_test.h" 19 #include "extensions/shell/test/shell_test.h"
19 #include "extensions/test/extension_test_message_listener.h" 20 #include "extensions/test/extension_test_message_listener.h"
20 21
21 namespace {
22
23 // TODO(lfg) Merge TestGuestViewManager and its factory with the one in chrome
24 // web_view_browsertest.cc.
25 class TestGuestViewManager : public extensions::GuestViewManager {
26 public:
27 explicit TestGuestViewManager(content::BrowserContext* context)
28 : GuestViewManager(context),
29 seen_guest_removed_(false),
30 web_contents_(NULL) {}
31
32 content::WebContents* WaitForGuestCreated() {
33 if (web_contents_)
34 return web_contents_;
35
36 created_message_loop_runner_ = new content::MessageLoopRunner;
37 created_message_loop_runner_->Run();
38 return web_contents_;
39 }
40
41 void WaitForGuestDeleted() {
42 if (seen_guest_removed_)
43 return;
44
45 deleted_message_loop_runner_ = new content::MessageLoopRunner;
46 deleted_message_loop_runner_->Run();
47 }
48
49 private:
50 // GuestViewManager override:
51 virtual void AddGuest(int guest_instance_id,
52 content::WebContents* guest_web_contents) OVERRIDE {
53 extensions::GuestViewManager::AddGuest(guest_instance_id,
54 guest_web_contents);
55 web_contents_ = guest_web_contents;
56 seen_guest_removed_ = false;
57
58 if (created_message_loop_runner_.get())
59 created_message_loop_runner_->Quit();
60 }
61
62 virtual void RemoveGuest(int guest_instance_id) OVERRIDE {
63 extensions::GuestViewManager::RemoveGuest(guest_instance_id);
64 web_contents_ = NULL;
65 seen_guest_removed_ = true;
66
67 if (deleted_message_loop_runner_.get())
68 deleted_message_loop_runner_->Quit();
69 }
70
71 bool seen_guest_removed_;
72 content::WebContents* web_contents_;
73 scoped_refptr<content::MessageLoopRunner> created_message_loop_runner_;
74 scoped_refptr<content::MessageLoopRunner> deleted_message_loop_runner_;
75 };
76
77 // Test factory for creating test instances of GuestViewManager.
78 class TestGuestViewManagerFactory : public extensions::GuestViewManagerFactory {
79 public:
80 TestGuestViewManagerFactory() : test_guest_view_manager_(NULL) {}
81
82 virtual ~TestGuestViewManagerFactory() {}
83
84 virtual extensions::GuestViewManager* CreateGuestViewManager(
85 content::BrowserContext* context) OVERRIDE {
86 return GetManager(context);
87 }
88
89 // This function gets called from GuestViewManager::FromBrowserContext(),
90 // where test_guest_view_manager_ is assigned to a linked_ptr that takes care
91 // of deleting it.
92 TestGuestViewManager* GetManager(content::BrowserContext* context) {
93 DCHECK(!test_guest_view_manager_);
94 test_guest_view_manager_ = new TestGuestViewManager(context);
95 return test_guest_view_manager_;
96 }
97
98 private:
99 TestGuestViewManager* test_guest_view_manager_;
100
101 DISALLOW_COPY_AND_ASSIGN(TestGuestViewManagerFactory);
102 };
103
104 } // namespace
105
106 namespace extensions { 22 namespace extensions {
107 23
108 // This class intercepts download request from the guest. 24 // This class intercepts download request from the guest.
109 class WebViewAPITest : public AppShellTest { 25 class WebViewAPITest : public AppShellTest {
110 protected: 26 protected:
111 void RunTest(const std::string& test_name, const std::string& app_location) { 27 void RunTest(const std::string& test_name, const std::string& app_location) {
112 base::FilePath test_data_dir; 28 base::FilePath test_data_dir;
113 PathService::Get(extensions::DIR_TEST_DATA, &test_data_dir); 29 PathService::Get(DIR_TEST_DATA, &test_data_dir);
114 test_data_dir = test_data_dir.AppendASCII(app_location.c_str()); 30 test_data_dir = test_data_dir.AppendASCII(app_location.c_str());
115 31
116 ASSERT_TRUE(extension_system_->LoadApp(test_data_dir)); 32 ASSERT_TRUE(extension_system_->LoadApp(test_data_dir));
117 extension_system_->LaunchApp(); 33 extension_system_->LaunchApp();
118 34
119 ExtensionTestMessageListener launch_listener("LAUNCHED", false); 35 ExtensionTestMessageListener launch_listener("LAUNCHED", false);
120 ASSERT_TRUE(launch_listener.WaitUntilSatisfied()); 36 ASSERT_TRUE(launch_listener.WaitUntilSatisfied());
121 37
122 const AppWindowRegistry::AppWindowList& app_window_list = 38 const AppWindowRegistry::AppWindowList& app_window_list =
123 AppWindowRegistry::Get(browser_context_)->app_windows(); 39 AppWindowRegistry::Get(browser_context_)->app_windows();
124 DCHECK(app_window_list.size() == 1); 40 DCHECK(app_window_list.size() == 1);
125 content::WebContents* embedder_web_contents = 41 content::WebContents* embedder_web_contents =
126 (*app_window_list.begin())->web_contents(); 42 (*app_window_list.begin())->web_contents();
127 43
128 ExtensionTestMessageListener done_listener("TEST_PASSED", false); 44 ExtensionTestMessageListener done_listener("TEST_PASSED", false);
129 done_listener.set_failure_message("TEST_FAILED"); 45 done_listener.set_failure_message("TEST_FAILED");
130 if (!content::ExecuteScript( 46 if (!content::ExecuteScript(
131 embedder_web_contents, 47 embedder_web_contents,
132 base::StringPrintf("runTest('%s')", test_name.c_str()))) { 48 base::StringPrintf("runTest('%s')", test_name.c_str()))) {
133 LOG(ERROR) << "Unable to start test."; 49 LOG(ERROR) << "Unable to start test.";
134 return; 50 return;
135 } 51 }
136 ASSERT_TRUE(done_listener.WaitUntilSatisfied()); 52 ASSERT_TRUE(done_listener.WaitUntilSatisfied());
137 } 53 }
138 54
139 WebViewAPITest() { 55 WebViewAPITest() { GuestViewManager::set_factory_for_testing(&factory_); }
140 extensions::GuestViewManager::set_factory_for_testing(&factory_);
141 }
142 56
143 private: 57 private:
144 TestGuestViewManagerFactory factory_; 58 TestGuestViewManagerFactory factory_;
145 }; 59 };
146 60
61 IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestAllowTransparencyAttribute) {
62 RunTest("testAllowTransparencyAttribute", "web_view/apitest");
63 }
64
147 IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestAPIMethodExistence) { 65 IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestAPIMethodExistence) {
148 RunTest("testAPIMethodExistence", "web_view/apitest"); 66 RunTest("testAPIMethodExistence", "web_view/apitest");
149 } 67 }
150 68
69 IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestAutosizeAfterNavigation) {
70 RunTest("testAutosizeAfterNavigation", "web_view/apitest");
71 }
72
73 IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestAutosizeBeforeNavigation) {
74 RunTest("testAutosizeBeforeNavigation", "web_view/apitest");
75 }
76
77 IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestAutosizeHeight) {
78 RunTest("testAutosizeHeight", "web_view/apitest");
79 }
80
81 IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestAutosizeRemoveAttributes) {
82 RunTest("testAutosizeRemoveAttributes", "web_view/apitest");
83 }
84
85 IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestAutosizeWithPartialAttributes) {
86 RunTest("testAutosizeWithPartialAttributes", "web_view/apitest");
87 }
88
151 } // namespace extensions 89 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/guest_view/web_view/test_guest_view_manager.cc ('k') | extensions/extensions.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698