Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 604443002: Mojo: Remove ProxyMessagePipeEndpoint::OnRemove(), etc. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@del_pmpe_run-x-del_mp_attach-x-move_paused_message_queue-x-del_pmpe_attach
Project:
chromium
Visibility:
Public.

Description

Mojo: Remove ProxyMessagePipeEndpoint::OnRemove(), etc. R=brettw@chromium.org Committed: https://crrev.com/b54744dac380cf4e98957a812049da5198b89631 Cr-Commit-Position: refs/heads/master@{#296857}

Patch Set 1 #

Patch Set 2 : remove comment #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -42 lines) Patch
M mojo/system/message_pipe.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mojo/system/message_pipe_endpoint.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 1 2 chunks +7 lines, -20 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 1 2 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/596363003/.)
6 years, 3 months ago (2014-09-24 19:25:43 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-24 19:29:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604443002/60001
6 years, 2 months ago (2014-09-26 00:18:20 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 789daf94c54f04513dd680e013ab04dceaf0a1a4
6 years, 2 months ago (2014-09-26 02:14:32 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 02:15:07 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b54744dac380cf4e98957a812049da5198b89631
Cr-Commit-Position: refs/heads/master@{#296857}

Powered by Google App Engine
This is Rietveld 408576698