Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596363003: Mojo: Remove ProxyMessagePipeEndpoint::Run(), etc. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@del_mp_attach-x-move_paused_message_queue-x-del_pmpe_attach
Project:
chromium
Visibility:
Public.

Description

Mojo: Remove ProxyMessagePipeEndpoint::Run(), etc. R=darin@chromium.org Committed: https://crrev.com/422b434274e09a95ca778dd29890d51ab2c15ae5 Cr-Commit-Position: refs/heads/master@{#296837}

Patch Set 1 #

Patch Set 2 : also remove is_peer_open_ #

Patch Set 3 : moar deletion #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Patch Set 6 : remove unused vars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -83 lines) Patch
M mojo/system/channel.cc View 1 2 3 4 5 3 chunks +0 lines, -6 lines 0 comments Download
M mojo/system/message_pipe.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/system/message_pipe.cc View 1 2 3 3 chunks +2 lines, -14 lines 0 comments Download
M mojo/system/message_pipe_endpoint.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 1 2 1 chunk +1 line, -14 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 1 2 3 4 chunks +2 lines, -40 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/600523002/.)
6 years, 3 months ago (2014-09-24 17:25:26 UTC) #1
darin (slow to review)
lgtm
6 years, 3 months ago (2014-09-24 17:35:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596363003/80001
6 years, 2 months ago (2014-09-25 21:45:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/2363)
6 years, 2 months ago (2014-09-25 21:57:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596363003/100001
6 years, 2 months ago (2014-09-25 22:03:09 UTC) #8
viettrungluu
Committed patchset #6 (id:100001) manually as 422b434 (presubmit successful).
6 years, 2 months ago (2014-09-26 00:10:43 UTC) #9
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/422b434274e09a95ca778dd29890d51ab2c15ae5 Cr-Commit-Position: refs/heads/master@{#296837}
6 years, 2 months ago (2014-09-26 00:10:46 UTC) #10
Zhenyao Mo
6 years, 2 months ago (2014-09-26 17:54:06 UTC) #11
Message was sent while issue was closed. 
On 2014/09/26 00:10:46, I haz the power (commit-bot) wrote:
> Patchset 6 (id:??) landed as
> https://crrev.com/422b434274e09a95ca778dd29890d51ab2c15ae5
> Cr-Commit-Position: refs/heads/master@{#296837}

This CL broke WebUIMojoTest.EndToEndPing in content_browsertests on Linux

Powered by Google App Engine
This is Rietveld 408576698