components/password_manager/core/browser/stub_password_manager_client.h - Issue 604293002: Improve logging in password manager internals page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.h

Issue 604293002: Improve logging in password manager internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/password_manager/core/browser/stub_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.h

diff --git a/components/password_manager/core/browser/stub_password_manager_client.h b/components/password_manager/core/browser/stub_password_manager_client.h

index df98851ecb53c41c71064093cd75319d8acfe696..15d10bf1d58a91494e317169a43d40761d9168f2 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.h

+++ b/components/password_manager/core/browser/stub_password_manager_client.h

@@ -22,7 +22,7 @@ class StubPasswordManagerClient : public PasswordManagerClient {

const std::string& username, const std::string& origin) const OVERRIDE;

virtual bool ShouldFilterAutofillResult(

const autofill::PasswordForm& form) OVERRIDE;

- virtual void PromptUserToSavePassword(

+ virtual bool PromptUserToSavePassword(

scoped_ptr<PasswordFormManager> form_to_save) OVERRIDE;

virtual void AutomaticPasswordSave(

scoped_ptr<PasswordFormManager> saved_manager) OVERRIDE;