components/password_manager/core/browser/password_manager_unittest.cc - Issue 604293002: Improve logging in password manager internals page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 604293002: Improve logging in password manager internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/stub_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index a2be320e1176e52632ec0709bd04ccb26e158e59..5406688308c32b21e126ccf8737e0664cd63bdd0 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -54,9 +54,10 @@ class MockPasswordManagerClient : public StubPasswordManagerClient {

MOCK_METHOD0(GetDriver, PasswordManagerDriver*());

// Workaround for scoped_ptr<> lacking a copy constructor.

- virtual void PromptUserToSavePassword(

+ virtual bool PromptUserToSavePassword(

scoped_ptr<PasswordFormManager> manager) OVERRIDE {

PromptUserToSavePasswordPtr(manager.release());

+ return false;

}

virtual void AutomaticPasswordSave(

scoped_ptr<PasswordFormManager> manager) OVERRIDE {