Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2726)

Unified Diff: content/public/android/java/res/layout-land/date_time_picker_dialog.xml

Issue 604243002: [Android] Add ScrollView to DateTimePicker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/android/java/res/layout/date_time_picker_dialog.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/res/layout-land/date_time_picker_dialog.xml
diff --git a/content/public/android/java/res/layout-land/date_time_picker_dialog.xml b/content/public/android/java/res/layout-land/date_time_picker_dialog.xml
index d44ab7ae9df73e0f117f2fec6c49f56153e063eb..8e343fd7adf4de35ace4e9845fb43336f3305e4e 100644
--- a/content/public/android/java/res/layout-land/date_time_picker_dialog.xml
+++ b/content/public/android/java/res/layout-land/date_time_picker_dialog.xml
@@ -5,29 +5,36 @@
found in the LICENSE file.
-->
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<!-- ScrollView is needed since sometimes the dialog does not fit in small screen devices. -->
+<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_gravity="center_horizontal"
- android:orientation="horizontal"
Ted C 2014/09/26 16:26:51 This used to be horizontal and you changed it to v
Changwan Ryu 2014/09/30 00:22:10 My bad... Fixed now. Also changed gravity as well,
- android:gravity="center">
+ android:layout_height="wrap_content">
- <DatePicker
- android:id="@+id/date_picker"
- android:layout_gravity="center_horizontal"
+ <LinearLayout
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:spinnersShown="true"
- android:calendarViewShown="false"
- android:contentDescription="@string/accessibility_datetime_picker_date"
- />
-
- <TimePicker
- android:id="@+id/time_picker"
android:layout_gravity="center_horizontal"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:contentDescription="@string/accessibility_datetime_picker_time"
- />
+ android:orientation="vertical"
+ android:gravity="center">
+
+ <DatePicker
+ android:id="@+id/date_picker"
+ android:layout_gravity="center_horizontal"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:spinnersShown="true"
+ android:calendarViewShown="false"
+ android:contentDescription="@string/accessibility_datetime_picker_date"
+ />
+
+ <TimePicker
+ android:id="@+id/time_picker"
+ android:layout_gravity="center_horizontal"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:contentDescription="@string/accessibility_datetime_picker_time"
+ />
+
+ </LinearLayout>
-</LinearLayout>
+</ScrollView>
« no previous file with comments | « no previous file | ui/android/java/res/layout/date_time_picker_dialog.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698