Chromium Code Reviews Chromium Code Reviews
Issue 604243002:
[Android] Add ScrollView to DateTimePicker (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved. | 2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 3 | 3 |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | 8 <!-- ScrollView is needed since sometimes the dialog does not fit in small scree n devices. --> |
| 9 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" | |
| 9 android:layout_width="wrap_content" | 10 android:layout_width="wrap_content" |
| 10 android:layout_height="wrap_content" | 11 android:layout_height="wrap_content"> |
| 11 android:layout_gravity="center_horizontal" | |
| 12 android:orientation="horizontal" | |
|
Ted C
2014/09/26 16:26:51
This used to be horizontal and you changed it to v
Changwan Ryu
2014/09/30 00:22:10
My bad... Fixed now. Also changed gravity as well,
| |
| 13 android:gravity="center"> | |
| 14 | 12 |
| 15 <DatePicker | 13 <LinearLayout |
| 16 android:id="@+id/date_picker" | |
| 17 android:layout_gravity="center_horizontal" | |
| 18 android:layout_width="wrap_content" | 14 android:layout_width="wrap_content" |
| 19 android:layout_height="wrap_content" | 15 android:layout_height="wrap_content" |
| 20 android:spinnersShown="true" | 16 android:layout_gravity="center_horizontal" |
| 21 android:calendarViewShown="false" | 17 android:orientation="vertical" |
| 22 android:contentDescription="@string/accessibility_datetime_picker_date" | 18 android:gravity="center"> |
| 23 /> | |
| 24 | 19 |
| 25 <TimePicker | 20 <DatePicker |
| 26 android:id="@+id/time_picker" | 21 android:id="@+id/date_picker" |
| 27 android:layout_gravity="center_horizontal" | 22 android:layout_gravity="center_horizontal" |
| 28 android:layout_width="wrap_content" | 23 android:layout_width="wrap_content" |
| 29 android:layout_height="wrap_content" | 24 android:layout_height="wrap_content" |
| 30 android:contentDescription="@string/accessibility_datetime_picker_time" | 25 android:spinnersShown="true" |
| 31 /> | 26 android:calendarViewShown="false" |
| 27 android:contentDescription="@string/accessibility_datetime_picker_da te" | |
| 28 /> | |
| 32 | 29 |
| 33 </LinearLayout> | 30 <TimePicker |
| 31 android:id="@+id/time_picker" | |
| 32 android:layout_gravity="center_horizontal" | |
| 33 android:layout_width="wrap_content" | |
| 34 android:layout_height="wrap_content" | |
| 35 android:contentDescription="@string/accessibility_datetime_picker_ti me" | |
| 36 /> | |
| 37 | |
| 38 </LinearLayout> | |
| 39 | |
| 40 </ScrollView> | |
| OLD | NEW |
