Issue 604023003: Fix bug in Subzero bitcode reader for insertelement instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 604023003: Fix bug in Subzero bitcode reader for insertelement instruction. (Closed)

Created:
6 years, 2 months ago by Karl

Modified:
6 years, 2 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Fix bug in Subzero bitcode reader for insertelement instruction. Instruction insertelement was incorrectly generating a result corresponding to the element type, instead of the updated vector type. BUG= None R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f0657dd84993473502477f45fb83a961b4eeec1c

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -15 lines)			Patch
M	src/PNaClTranslator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests_lit/llvm2ice_tests/vector-ops.ll	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	tests_lit/reader_tests/insertextract.ll	View	7 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Karl

6 years, 2 months ago (2014-09-25 21:04:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as f0657dd (presubmit successful).