Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 603883002: Remove default args to several PageWidgetDelegate members. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
kenrb, Nate Chapin
CC:
blink-reviews, mkwst+moarreviews_chromium.org, kenrb
Project:
blink
Visibility:
Public.

Description

Remove default args to several PageWidgetDelegate members. No one passes the correct local root here yet; eventually, something.... BUG=411993 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182705

Patch Set 1 #

Patch Set 2 : Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -51 lines) Patch
M Source/web/PageWidgetDelegate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 4 chunks +21 lines, -39 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
6 years, 2 months ago (2014-09-25 17:13:31 UTC) #2
Nate Chapin
LGTM
6 years, 2 months ago (2014-09-25 17:22:10 UTC) #3
kenrb
Thanks for cleaning this up Daniel. I will fix WebViewImpl in the not-too-distant future, where ...
6 years, 2 months ago (2014-09-25 17:25:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603883002/20001
6 years, 2 months ago (2014-09-25 18:59:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 182705
6 years, 2 months ago (2014-09-25 19:04:09 UTC) #8
dcheng
6 years, 2 months ago (2014-09-25 22:05:00 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/600823005/ by dcheng@chromium.org.

The reason for reverting is: Broke several cross-site iframe tests..

Powered by Google App Engine
This is Rietveld 408576698