Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: chrome/browser/autofill/form_structure_browsertest.cc

Issue 603853002: Re-enable some autofill tests that were previously disabled for flake. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/form_structure_browsertest.cc
diff --git a/chrome/browser/autofill/form_structure_browsertest.cc b/chrome/browser/autofill/form_structure_browsertest.cc
index ed186a911ff9ec95ea1d6b054162745e07d95faf..bb5e4318f6f4ce71e495df2534511fceb530167d 100644
--- a/chrome/browser/autofill/form_structure_browsertest.cc
+++ b/chrome/browser/autofill/form_structure_browsertest.cc
@@ -102,9 +102,7 @@ std::string FormStructureBrowserTest::FormStructuresToString(
}
// Heuristics tests timeout on Windows. See http://crbug.com/85276
-// Also on ChromeOS/Aura. See crbug.com/173621
-// On Linux too. See crbug.com/323093
-#if defined(USE_AURA)
+#if defined(OS_WIN)
#define MAYBE_DataDrivenHeuristics(n) DISABLED_DataDrivenHeuristics##n
#else
#define MAYBE_DataDrivenHeuristics(n) DataDrivenHeuristics##n
@@ -251,8 +249,9 @@ IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest,
kFileNamePattern);
}
+// This test has real failures. http://crbug.com/323093
IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest,
- MAYBE_DataDrivenHeuristics(16)) {
+ DISABLED_DataDrivenHeuristics16) {
const base::FilePath::CharType kFileNamePattern[] =
FILE_PATH_LITERAL("16_*.html");
RunDataDrivenTest(GetInputDirectory(kTestName),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698