Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/autofill/form_structure_browsertest.cc

Issue 603853002: Re-enable some autofill tests that were previously disabled for flake. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 forms_string += " | " + base::UTF16ToUTF8((*field_iter)->name); 95 forms_string += " | " + base::UTF16ToUTF8((*field_iter)->name);
96 forms_string += " | " + base::UTF16ToUTF8((*field_iter)->label); 96 forms_string += " | " + base::UTF16ToUTF8((*field_iter)->label);
97 forms_string += " | " + base::UTF16ToUTF8((*field_iter)->value); 97 forms_string += " | " + base::UTF16ToUTF8((*field_iter)->value);
98 forms_string += "\n"; 98 forms_string += "\n";
99 } 99 }
100 } 100 }
101 return forms_string; 101 return forms_string;
102 } 102 }
103 103
104 // Heuristics tests timeout on Windows. See http://crbug.com/85276 104 // Heuristics tests timeout on Windows. See http://crbug.com/85276
105 // Also on ChromeOS/Aura. See crbug.com/173621 105 #if defined(OS_WIN)
106 // On Linux too. See crbug.com/323093
107 #if defined(USE_AURA)
108 #define MAYBE_DataDrivenHeuristics(n) DISABLED_DataDrivenHeuristics##n 106 #define MAYBE_DataDrivenHeuristics(n) DISABLED_DataDrivenHeuristics##n
109 #else 107 #else
110 #define MAYBE_DataDrivenHeuristics(n) DataDrivenHeuristics##n 108 #define MAYBE_DataDrivenHeuristics(n) DataDrivenHeuristics##n
111 #endif 109 #endif
112 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest, DataDrivenHeuristics00) { 110 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest, DataDrivenHeuristics00) {
113 const base::FilePath::CharType kFileNamePattern[] = 111 const base::FilePath::CharType kFileNamePattern[] =
114 FILE_PATH_LITERAL("00_*.html"); 112 FILE_PATH_LITERAL("00_*.html");
115 RunDataDrivenTest(GetInputDirectory(kTestName), 113 RunDataDrivenTest(GetInputDirectory(kTestName),
116 GetOutputDirectory(kTestName), 114 GetOutputDirectory(kTestName),
117 kFileNamePattern); 115 kFileNamePattern);
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 242
245 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest, 243 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest,
246 MAYBE_DataDrivenHeuristics(15)) { 244 MAYBE_DataDrivenHeuristics(15)) {
247 const base::FilePath::CharType kFileNamePattern[] = 245 const base::FilePath::CharType kFileNamePattern[] =
248 FILE_PATH_LITERAL("15_*.html"); 246 FILE_PATH_LITERAL("15_*.html");
249 RunDataDrivenTest(GetInputDirectory(kTestName), 247 RunDataDrivenTest(GetInputDirectory(kTestName),
250 GetOutputDirectory(kTestName), 248 GetOutputDirectory(kTestName),
251 kFileNamePattern); 249 kFileNamePattern);
252 } 250 }
253 251
252 // This test has real failures. http://crbug.com/323093
254 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest, 253 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest,
255 MAYBE_DataDrivenHeuristics(16)) { 254 DISABLED_DataDrivenHeuristics16) {
256 const base::FilePath::CharType kFileNamePattern[] = 255 const base::FilePath::CharType kFileNamePattern[] =
257 FILE_PATH_LITERAL("16_*.html"); 256 FILE_PATH_LITERAL("16_*.html");
258 RunDataDrivenTest(GetInputDirectory(kTestName), 257 RunDataDrivenTest(GetInputDirectory(kTestName),
259 GetOutputDirectory(kTestName), 258 GetOutputDirectory(kTestName),
260 kFileNamePattern); 259 kFileNamePattern);
261 } 260 }
262 261
263 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest, 262 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest,
264 MAYBE_DataDrivenHeuristics(17)) { 263 MAYBE_DataDrivenHeuristics(17)) {
265 const base::FilePath::CharType kFileNamePattern[] = 264 const base::FilePath::CharType kFileNamePattern[] =
266 FILE_PATH_LITERAL("17_*.html"); 265 FILE_PATH_LITERAL("17_*.html");
267 RunDataDrivenTest(GetInputDirectory(kTestName), 266 RunDataDrivenTest(GetInputDirectory(kTestName),
268 GetOutputDirectory(kTestName), 267 GetOutputDirectory(kTestName),
269 kFileNamePattern); 268 kFileNamePattern);
270 } 269 }
271 270
272 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest, 271 IN_PROC_BROWSER_TEST_F(FormStructureBrowserTest,
273 MAYBE_DataDrivenHeuristics(20)) { 272 MAYBE_DataDrivenHeuristics(20)) {
274 const base::FilePath::CharType kFileNamePattern[] = 273 const base::FilePath::CharType kFileNamePattern[] =
275 FILE_PATH_LITERAL("20_*.html"); 274 FILE_PATH_LITERAL("20_*.html");
276 RunDataDrivenTest(GetInputDirectory(kTestName), 275 RunDataDrivenTest(GetInputDirectory(kTestName),
277 GetOutputDirectory(kTestName), 276 GetOutputDirectory(kTestName),
278 kFileNamePattern); 277 kFileNamePattern);
279 } 278 }
280 279
281 } // namespace autofill 280 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698