Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Issue 603853002: Re-enable some autofill tests that were previously disabled for flake. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable some autofill tests that were previously disabled for flake. They don't seem to be flaky for me locally. BUG=173621 Committed: https://crrev.com/a4c2d5edb4e5365535c53f85c660510988014547 Cr-Commit-Position: refs/heads/master@{#296864}

Patch Set 1 #

Patch Set 2 : fix broken macro #

Total comments: 4

Patch Set 3 : isherman review #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/autofill/form_structure_browsertest.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
6 years, 2 months ago (2014-09-25 21:50:26 UTC) #2
Ilya Sherman
LGTM % nits. Thanks. https://codereview.chromium.org/603853002/diff/20001/chrome/browser/autofill/form_structure_browsertest.cc File chrome/browser/autofill/form_structure_browsertest.cc (right): https://codereview.chromium.org/603853002/diff/20001/chrome/browser/autofill/form_structure_browsertest.cc#newcode106 chrome/browser/autofill/form_structure_browsertest.cc:106: // On Linux too. See ...
6 years, 2 months ago (2014-09-25 21:52:36 UTC) #3
Evan Stade
https://codereview.chromium.org/603853002/diff/20001/chrome/browser/autofill/form_structure_browsertest.cc File chrome/browser/autofill/form_structure_browsertest.cc (right): https://codereview.chromium.org/603853002/diff/20001/chrome/browser/autofill/form_structure_browsertest.cc#newcode106 chrome/browser/autofill/form_structure_browsertest.cc:106: // On Linux too. See crbug.com/323093 On 2014/09/25 21:52:36, ...
6 years, 2 months ago (2014-09-25 22:08:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603853002/40001
6 years, 2 months ago (2014-09-25 22:09:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/18086)
6 years, 2 months ago (2014-09-26 00:35:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603853002/60001
6 years, 2 months ago (2014-09-26 00:46:30 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as d90a85984d995a228402aa9d67c4a6aabb391739
6 years, 2 months ago (2014-09-26 02:33:38 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 02:34:15 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a4c2d5edb4e5365535c53f85c660510988014547
Cr-Commit-Position: refs/heads/master@{#296864}

Powered by Google App Engine
This is Rietveld 408576698