Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 603813002: Do not trigger touch adjustment in AddressDetectionTest#testAddressLimits (Closed)

Created:
6 years, 2 months ago by Zeeshan Qureshi
Modified:
6 years, 2 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not trigger touch adjustment in AddressDetectionTest#testAddressLimits Blink behaviour is being changed to re-use the hit test node for content detection so this test shouldn't trigger touch adjustment as future changes to adjustment would cause this to fail. This is part 1 of 2, will be followed by https://codereview.chromium.org/604573002 BUG=381728, 416746 Committed: https://crrev.com/8bac2728a9e154010aaf8cf210d9731f82b01987 Cr-Commit-Position: refs/heads/master@{#297546}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use TODO #

Total comments: 1

Patch Set 3 : Update test to not trigger touch adjustment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/test/data/android/device_files/content_detection/geo_address_limits.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (3 generated)
Zeeshan Qureshi
Jared / Ruslan PTAL.
6 years, 2 months ago (2014-09-24 23:34:49 UTC) #2
Zeeshan Qureshi
+cc rbyers
6 years, 2 months ago (2014-09-24 23:39:27 UTC) #3
jdduke (slow)
If this is blocking rolls, then lgtm (assuming it's fine with aruslan@) with nit. https://codereview.chromium.org/603813002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java ...
6 years, 2 months ago (2014-09-25 00:21:25 UTC) #4
Zeeshan Qureshi
Thanks, updated. The blink side hasn't landed yet, I'm just lining this up and will ...
6 years, 2 months ago (2014-09-25 00:25:52 UTC) #5
jdduke (slow)
On 2014/09/24 23:39:27, Zeeshan Qureshi wrote: > +cc rbyers Wait, this is the first patch? ...
6 years, 2 months ago (2014-09-25 00:26:02 UTC) #6
Zeeshan Qureshi
aruslan@ says he's not the right reviewer for this. Jared would you know who'd be ...
6 years, 2 months ago (2014-09-30 18:51:43 UTC) #8
jdduke (slow)
https://codereview.chromium.org/603813002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java File content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java (right): https://codereview.chromium.org/603813002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java#newcode73 content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java:73: // TODO(zeeshanq): Enable after crrev.com/604573002 lands I don't think ...
6 years, 2 months ago (2014-09-30 19:22:21 UTC) #9
Zeeshan Qureshi
Updated. The problem was that putting the text anywhere near a div with content in ...
6 years, 2 months ago (2014-09-30 22:23:01 UTC) #10
jdduke (slow)
On 2014/09/30 22:23:01, Zeeshan Qureshi wrote: > Updated. > > The problem was that putting ...
6 years, 2 months ago (2014-09-30 22:29:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603813002/40001
6 years, 2 months ago (2014-09-30 22:35:12 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 6b8deabcefe30cec9834c006b89f8218c679757c
6 years, 2 months ago (2014-09-30 23:37:02 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 23:38:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8bac2728a9e154010aaf8cf210d9731f82b01987
Cr-Commit-Position: refs/heads/master@{#297546}

Powered by Google App Engine
This is Rietveld 408576698