Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 604573002: Eliminate hit test for content detection on GestureTap. (Closed)

Created:
6 years, 3 months ago by Zeeshan Qureshi
Modified:
6 years, 2 months ago
CC:
blink-reviews, jdduke (slow), mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Eliminate hit test for content detection on GestureTap. Currently WebViewImpl does a redundant hit test for content detection even though we've already done event targeting before it. This patch updates it to use the hit test result from the targeted event. This also has the positive side effect that content detection uses the touch adjusted node. This is part 2 of 2, depends on https://codereview.chromium.org/603813002/ BUG=381728, 416746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182997

Patch Set 1 #

Patch Set 2 : Update hit test counts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M LayoutTests/fast/events/hit-test-counts-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Zeeshan Qureshi
Rick / Alex PTAL.
6 years, 2 months ago (2014-09-24 23:40:20 UTC) #2
Rick Byers
Looks good, but let's discuss http://crbug.com/417534 before landing this.
6 years, 2 months ago (2014-09-25 01:11:49 UTC) #3
Rick Byers
Ok we agreed we should proceed with this change (highlighting one thing but activating something ...
6 years, 2 months ago (2014-09-25 19:29:52 UTC) #4
aelias_OOO_until_Jul13
lgtm
6 years, 2 months ago (2014-09-29 20:19:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604573002/20001
6 years, 2 months ago (2014-09-30 22:34:39 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 22:45:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182997

Powered by Google App Engine
This is Rietveld 408576698