Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 603783002: Replaced DCHECK with CHECK to detect invalid socket usage. (Closed)

Created:
6 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replaced DCHECK with CHECK to detect invalid socket usage. Issue like 121085 or 320427 could be caused by writing request on busy sockets. BUG=121085 Committed: https://crrev.com/63b47546afb414f9e62a9a64518a92c5aeb0ce63 Cr-Commit-Position: refs/heads/master@{#297195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M net/socket/socket_libevent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/tcp_socket_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Vitaly Buka (NO REVIEWS)
same as https://codereview.chromium.org/580163003/ for TCP sockets
6 years, 2 months ago (2014-09-24 22:13:00 UTC) #2
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-09-26 03:27:09 UTC) #3
Vitaly Buka (NO REVIEWS)
On 2014/09/26 03:27:09, Ryan Hamilton wrote: > lgtm thanks. I'll wait to commit after branch.
6 years, 2 months ago (2014-09-26 04:05:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603783002/1
6 years, 2 months ago (2014-09-29 17:09:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1399bdcc01a895e874835f60549ad5e963862363
6 years, 2 months ago (2014-09-29 17:14:26 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 17:15:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63b47546afb414f9e62a9a64518a92c5aeb0ce63
Cr-Commit-Position: refs/heads/master@{#297195}

Powered by Google App Engine
This is Rietveld 408576698