net/socket/socket_libevent.cc - Issue 603783002: Replaced DCHECK with CHECK to detect invalid socket usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socket_libevent.cc

Issue 603783002: Replaced DCHECK with CHECK to detect invalid socket usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socket_libevent.cc

diff --git a/net/socket/socket_libevent.cc b/net/socket/socket_libevent.cc

index cd40e49afa04efc3071f25e8860b411336d26fe7..5f16c929ab202fd4c61ba4ed5070cb523fb0353d 100644

--- a/net/socket/socket_libevent.cc

+++ b/net/socket/socket_libevent.cc

@@ -230,7 +230,7 @@ int SocketLibevent::Read(IOBuffer* buf,

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK_NE(kInvalidSocket, socket_fd_);

DCHECK(!waiting_connect_);

- DCHECK(read_callback_.is_null());

+ CHECK(read_callback_.is_null());

// Synchronous operation not supported

DCHECK(!callback.is_null());

DCHECK_LT(0, buf_len);

@@ -258,7 +258,7 @@ int SocketLibevent::Write(IOBuffer* buf,

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK_NE(kInvalidSocket, socket_fd_);

DCHECK(!waiting_connect_);

- DCHECK(write_callback_.is_null());

+ CHECK(write_callback_.is_null());

// Synchronous operation not supported

DCHECK(!callback.is_null());

DCHECK_LT(0, buf_len);

« no previous file with comments | « no previous file | net/socket/tcp_socket_win.cc » ('j') | no next file with comments »