Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 603533002: [turbofan] more verification of rpo (Closed)

Created:
6 years, 3 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] more verification of rpo R=titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24630

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M src/compiler/verifier.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcarney
ptal
6 years, 3 months ago (2014-09-24 11:33:38 UTC) #2
titzer
https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc#newcode879 src/compiler/scheduler.cc:879: } Can we put this new code into ScheduleVerifier::Run()?
6 years, 2 months ago (2014-09-25 14:52:58 UTC) #3
dcarney
https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc#newcode879 src/compiler/scheduler.cc:879: } On 2014/09/25 14:52:58, titzer wrote: > Can we ...
6 years, 2 months ago (2014-09-29 13:29:54 UTC) #4
titzer
On 2014/09/29 13:29:54, dcarney wrote: > https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc > File src/compiler/scheduler.cc (right): > > https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc#newcode879 > ...
6 years, 2 months ago (2014-10-15 12:00:31 UTC) #5
dcarney
6 years, 2 months ago (2014-10-15 12:15:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698