[turbofan] more verification of rpo

src/compiler/verifier.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/verifier.h"
 
 #include <deque>
 #include <queue>
 
 #include "src/compiler/generic-algorithm.h"
@@ skipping 286 matching lines @@
   Zone tmp_zone(schedule->zone()->isolate());
   Zone* zone = &tmp_zone;
   BasicBlock* start = schedule->start();
   BasicBlockVector* rpo_order = schedule->rpo_order();
 
   // Verify the RPO order contains only blocks from this schedule.
   CHECK_GE(count, static_cast<int>(rpo_order->size()));
   for (BasicBlockVector::iterator b = rpo_order->begin(); b != rpo_order->end();
        ++b) {
     CHECK_EQ((*b), schedule->GetBlockById((*b)->id()));
+    // All predecessors and successors should be in rpo and in this schedule.
+    BasicBlock::Predecessors p = (*b)->predecessors();
+    for (BasicBlock::Predecessors::iterator j = p.begin(); j != p.end(); ++j) {
+      CHECK_GE((*j)->rpo_number_, 0);
+      CHECK_EQ((*j), schedule->GetBlockById((*j)->id()));
+    }
+    BasicBlock::Successors s = (*b)->successors();
+    for (BasicBlock::Successors::iterator j = s.begin(); j != s.end(); ++j) {
+      CHECK_GE((*j)->rpo_number_, 0);
+      CHECK_EQ((*j), schedule->GetBlockById((*j)->id()));
+    }
   }
 
   // Verify RPO numbers of blocks.
   CHECK_EQ(start, rpo_order->at(0));  // Start should be first.
   for (size_t b = 0; b < rpo_order->size(); b++) {
     BasicBlock* block = rpo_order->at(b);
     CHECK_EQ(static_cast<int>(b), block->rpo_number_);
     BasicBlock* dom = block->dominator_;
     if (b == 0) {
       // All blocks except start should have a dominator.
@@ skipping 129 matching lines @@
     // Check inputs for all nodes in the block.
     for (size_t i = 0; i < block->nodes_.size(); i++) {
       Node* node = block->nodes_[i];
       CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1);
     }
   }
 }
 }
 }
 }  // namespace v8::internal::compiler